Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5062] Update Product Docs with Blackout Period #592

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

mtsuji-cobalt
Copy link
Contributor

@mtsuji-cobalt mtsuji-cobalt commented Dec 10, 2024

Changelog

Added

  • New dedicated page for DAST Blackout Periods

Changed

  • As a bonus, updated text sizes for Reduced Scope doc for consistency

Preview This Change

To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/

Variables

Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:

{{% asset-categories %}}

You’ve found a shortcode that we include in multiple documents.

You’ll find the content of the shortcode in the following directory:

https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes

That shortcode has the same base name as what you see in the PR, such as asset-categories.html.

Checklist for PR Author

[ ] Did you check for broken links and alt text?

Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for cobalt-docs ready!

Name Link
🔨 Latest commit 7abb345
🔍 Latest deploy log https://app.netlify.com/sites/cobalt-docs/deploys/67857164d52c2b0008347a9e
😎 Deploy Preview https://deploy-preview-592--cobalt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mtsuji-cobalt mtsuji-cobalt marked this pull request as ready for review January 13, 2025 14:04
@mtsuji-cobalt mtsuji-cobalt requested a review from a team January 13, 2025 14:04
Copy link
Contributor

@mahmoudadly-cobalt mahmoudadly-cobalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small notes.


- While a blackout period is active, no new scans will be initiated, and any in-progress scans will be paused.
- Ensure your blackout periods do not overlap with critical security testing windows to maintain continuous vulnerability assessment.
- Consider setting reminders for upcoming blackout periods to avoid unintended lapses in security coverage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand which reminders.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI added in this one, and I think it means to just set up reminders for yourself to know when the blackout periods are (not in-app but something nice to do on your own). I can remove it if it's confusing in any way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently we've been using red rectangles to highlight buttons or sections in the docs. Like in the integration builder. Would be nice to have similar visuals added in new screenshots.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, the visuals are all over the place in our docs. Historically, the tech writers used the purple to highlight things in screenshots. I think Design needs to set standards around this one.

Copy link
Member

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants